Skip to content

vendor: update openshift/api to include some alibaba infra changes#5498

Closed
staebler wants to merge 3 commits intoopenshift:masterfrom
staebler:update_api_for_alibaba
Closed

vendor: update openshift/api to include some alibaba infra changes#5498
staebler wants to merge 3 commits intoopenshift:masterfrom
staebler:update_api_for_alibaba

Conversation

@staebler
Copy link
Copy Markdown
Contributor

@staebler staebler commented Dec 17, 2021 •
edited
Loading

  • Update openshift/api to 6e0b1eb97188.
  • Update kube modules to v0.23.0.
  • Update controller-runtime to v0.11.0.
  • Remove unused terraform-provider-kubernetes.
  • Updated the hack/verify-codegen.sh script to use an image containing go 1.17, rather than go 1.16.

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 17, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 17, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from staebler after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@staebler staebler force-pushed the update_api_for_alibaba branch from 7f26893 to a9071df Compare December 17, 2021 19:30
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 17, 2021
@staebler staebler changed the title vendor: update openshift/api to include some alibaba infra changes Bug 2033536: vendor: update openshift/api to include some alibaba infra changes Dec 17, 2021
@openshift-ci openshift-ci Bot added bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 17, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 17, 2021

@staebler: This pull request references Bugzilla bug 2033536, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jianli-wei

Details

In response to this:

Bug 2033536: vendor: update openshift/api to include some alibaba infra changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested a review from jianli-wei December 17, 2021 19:50
@staebler
vendor: update openshift/api to include some alibaba infra changes
a829541 
* Update openshift/api to 6e0b1eb97188.
* Update kube modules to v0.23.0.
* Update controller-runtime to v0.11.0.
* Remove unused terraform-provider-kubernetes.
@staebler
hack: use go 1.17 for verifying codegen
ca77dac 
The hack/verify-codegen.sh script was using an image that included
go 1.16. However, the updated k8s.io/json module calls the
`(reflect.StructField) IsExported` function, which is new in go 1.17.
Consequently, the script needs to be updated to use an image that
include go 1.17 rather than 1.16.
@staebler staebler force-pushed the update_api_for_alibaba branch from a9071df to ca77dac Compare December 17, 2021 22:04
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 17, 2021

@staebler: This pull request references Bugzilla bug 2033536, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.10.0) matches configured target release for branch (4.10.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact:
/cc @jianli-wei

Details

In response to this:

Bug 2033536: vendor: update openshift/api to include some alibaba infra changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 18, 2021

@staebler: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-metal-ipi-ovn-ipv6 ca77dac link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-ibmcloud ca77dac link false /test e2e-ibmcloud
ci/prow/e2e-crc ca77dac link false /test e2e-crc
ci/prow/e2e-aws-workers-rhel7 ca77dac link false /test e2e-aws-workers-rhel7
ci/prow/e2e-aws-workers-rhel8 ca77dac link false /test e2e-aws-workers-rhel8
ci/prow/e2e-openstack ca77dac link false /test e2e-openstack
ci/prow/e2e-aws-upgrade ca77dac link true /test e2e-aws-upgrade
ci/prow/e2e-aws-single-node ca77dac link false /test e2e-aws-single-node

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@staebler staebler mentioned this pull request Dec 18, 2021
Closed
@kwoodson
Copy link
Copy Markdown

kwoodson commented Dec 19, 2021

@staebler I was able to install a cluster without this PR. I'm not saying we shouldn't take it but I'm not sure it is required at this time.

@jianli-wei
Copy link
Copy Markdown
Contributor

jianli-wei commented Dec 20, 2021

/Lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2021
@openshift-ci openshift-ci Bot mentioned this pull request Dec 20, 2021
Merged
@staebler
Copy link
Copy Markdown
Contributor Author

staebler commented Dec 21, 2021

@staebler I was able to install a cluster without this PR. I'm not saying we shouldn't take it but I'm not sure it is required at this time.

Since this is not required to fix the BZ, I am removing the link to the BZ and closing the PR.
/retitle vendor: update openshift/api to include some alibaba infra changes
/close

@openshift-ci openshift-ci Bot changed the title Bug 2033536: vendor: update openshift/api to include some alibaba infra changes vendor: update openshift/api to include some alibaba infra changes Dec 21, 2021
@openshift-ci openshift-ci Bot removed bugzilla/severity-urgent Referenced Bugzilla bug's severity is urgent for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Dec 21, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 21, 2021

@staebler: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

vendor: update openshift/api to include some alibaba infra changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot closed this Dec 21, 2021
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 21, 2021

@staebler: Closed this PR.

Details

In response to this:

@staebler I was able to install a cluster without this PR. I'm not saying we shouldn't take it but I'm not sure it is required at this time.

Since this is not required to fix the BZ, I am removing the link to the BZ and closing the PR.
/retitle vendor: update openshift/api to include some alibaba infra changes
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@patrickdillon patrickdillon Awaiting requested review from patrickdillon

@squidboylan squidboylan Awaiting requested review from squidboylan

@jianli-wei jianli-wei Awaiting requested review from jianli-wei

Assignees

@jianli-wei jianli-wei

Labels

lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@staebler @kwoodson @jianli-wei